fix(i18n): fill missing settings keys across 9 locales#710
Open
AvinashShrivastav wants to merge 2 commits into
Open
fix(i18n): fill missing settings keys across 9 locales#710AvinashShrivastav wants to merge 2 commits into
AvinashShrivastav wants to merge 2 commits into
Conversation
Add missing translation keys to es, fr, it, ko, nl, pt-BR, ru, zh-CN, and zh-TW that were flagged by npm run i18n:check. Keys added per locale: - es, fr, pt-BR: temporalZoomMotionBlur group, motionPresets group, cursorSpring group (stiffness/damping/mass), cursorClickEffects block - it, ru: cursorClickEffects block only - ko, nl: temporalZoomMotionBlur group, motionPresets group, cursorSpring group, cursorClickEffects block - zh-CN: temporalZoomMotionBlur group, cursorClickEffects block - zh-TW: temporalZoomMotionBlur group, motionPresets group, cursorSpring group, cursorClickEffects block Also removed extra captions keys (editCurrent, editSaved) from es, fr, ko, nl, pt-BR, zh-TW that were not present in the English source. Passes: npm run i18n:check reports 'locale files are structurally consistent'
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds new localization keys for temporal zoom motion blur, motion presets, and cursor click effects across multiple settings locales, and removes two caption editing keys from several of them. ChangesSettings locale updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/i18n/locales/ko/settings.json`:
- Around line 74-76: Several Korean localization strings in settings.json are
machine-corrupted and need to be rewritten with natural Korean before release.
Review the affected copy under the smooth entry and the other impacted
description keys in the same locale file, then replace phrases like “세련된 레블”,
“셋스러운”, “령이”, “훈레이션”, and “포격적으로” with clean, user-facing Korean while
preserving each setting’s meaning and tone.
In `@src/i18n/locales/nl/settings.json`:
- Around line 109-112: The Dutch click-effect description in the locale entry
under the “none” setting contains a typo: update the text in the settings
translation so “cursorbeweiging” is corrected to “cursorbeweging” in the
description string.
In `@src/i18n/locales/pt-BR/settings.json`:
- Around line 65-68: The new pt-BR motion preset copy in settings.json lost its
Portuguese diacritics, so update the affected locale strings under the motion
preset entries to use proper Brazilian Portuguese accents. Fix the values for
motionPresetsTitle, motionPresetsZoomHint, animationPresets, and
cursorMotionPresets so they read naturally with the correct accented forms,
matching the style of the rest of the pt-BR locale file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3064e57e-e9c8-4a01-bf28-e0a5ec0997ea
📒 Files selected for processing (9)
src/i18n/locales/es/settings.jsonsrc/i18n/locales/fr/settings.jsonsrc/i18n/locales/it/settings.jsonsrc/i18n/locales/ko/settings.jsonsrc/i18n/locales/nl/settings.jsonsrc/i18n/locales/pt-BR/settings.jsonsrc/i18n/locales/ru/settings.jsonsrc/i18n/locales/zh-CN/settings.jsonsrc/i18n/locales/zh-TW/settings.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fill missing translation keys across 9 non-English locales (
es,fr,it,ko,nl,pt-BR,ru,zh-CN,zh-TW) insettings.json. Keys were identified and verified usingnpm run i18n:check.Motivation
npm run i18n:checkwas failing with 100+ missing key errors. Non-English users were seeing English fallback text for cursor click effects, motion presets, spring physics controls, and temporal zoom blur settings introduced in recent updates. This PR makes all locales structurally consistent with the English source.Type of Change
Related Issue(s)
N/A
Testing Guide
Run the i18n consistency check:
npm run i18n:check # Expected: "locale files are structurally consistent"Checklist
Summary by CodeRabbit
New Features
Bug Fixes